Avoid batch reading of nested decimals as this reader is not implemented#24440
Merged
tdcmeehan merged 1 commit intoprestodb:masterfrom Jan 29, 2025
Merged
Conversation
f6eee39 to
c725600
Compare
tdcmeehan
reviewed
Jan 28, 2025
c725600 to
7d61625
Compare
tdcmeehan
approved these changes
Jan 29, 2025
This was referenced Mar 10, 2025
jp-sivaprasad
pushed a commit
to jp-sivaprasad/presto
that referenced
this pull request
Mar 10, 2025
30 tasks
30 tasks
This was referenced May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid batch reading (set with
hive.parquet-batch-read-optimization-enabled=true) of nested decimals as this reader is not implemented.Reading a nested decimal column defined as:
without this PR results in the following error:
Motivation and Context
Fixes #23877
Test Plan
Added tests that fail without this PR:
testNestedArraysDecimalBackedByINT32testNestedArraysDecimalBackedByINT64testNestedArraysShortDecimalBackedByBinaryContributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.